Adding ZSA Orchard Action Description encoding details #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for zcash-zips-qedit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
PaulLaux
approved these changes
May 31, 2023
zip-0226.rst
Outdated
| +=======+===============+=============================+===========================================================================================================================+ | ||
| | 32 | ``AssetBase`` | ``byte[32]`` | For the Orchard-based ZSA protocol, this is the encoding of the Asset Base :math:`\mathsf{AssetBase}^{\mathsf{Orchard}}`. | | ||
| +-------+---------------+-----------------------------+---------------------------------------------------------------------------------------------------------------------------+ | ||
| | 8 | ``valueBurn`` | :math:`\{1 .. 2^{64} - 1\}` | The amount of the Asset Base being burnt. | |
There was a problem hiding this comment.
The amount being burnt. will be enough
| |``852 * nActionsOrchard`` |``vActionsOrchard`` |``ZSAOrchardAction[nActionsOrchard]`` |A sequence of ZSA Orchard Action descriptions, encoded per | | ||
| | | | |the `ZSA Orchard Action Description Encoding`_. **[UPDATED FOR ZSA]**| | ||
| +-----------------------------+--------------------------+-------------------------------------------+---------------------------------------------------------------------+ | ||
| |``1`` |``flagsOrchard`` |``byte`` | | |
There was a problem hiding this comment.
We will need a spec for flagsOrchard and how it is translates to finilized. (a different pr)
PaulLaux
pushed a commit
that referenced
this pull request
Oct 4, 2023
This adds details of the changes to the Orchard Action encodings and the changes to the transaction format that occur due to the ZSA Protocol. It also improves the formatting of existing tables for Asset Burn.
vivek-arte
added a commit
that referenced
this pull request
Feb 12, 2024
This adds details of the changes to the Orchard Action encodings and the changes to the transaction format that occur due to the ZSA Protocol. It also improves the formatting of existing tables for Asset Burn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds details of the changes to the Orchard Action encodings and the changes to the transaction format that occur due to the ZSA Protocol. It also improves the formatting of existing tables for Asset Burns.