Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging upstream changes and repository restructuring into zsa1 #58

Merged
merged 282 commits into from
Aug 12, 2024

Conversation

vivek-arte
Copy link

This PR catches our latest changes up with the rearranging of the repository performed upstream.

conradoplg and others added 30 commits August 25, 2022 20:10
Applies comments from the last ZIP Sync this was reviewed in.
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: Kris Nuttycombe <kris@nutty.land>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: Kris Nuttycombe <kris@nutty.land>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: Deirdre Connolly <deirdre@zfnd.org>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Previously it did not correctly handle unsynced wallets, or transparent TXOs when
auto-shielding is enabled.

Also, move some unedited text into the relevant sections.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: Kris Nuttycombe <kris@nutty.land>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
str4d and others added 25 commits July 18, 2024 13:44
their contributions.

Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
[ZIP 312] FROST for Spend Authorization Signatures
Co-authored-by: Jack Grigg <jack@electriccoin.co>
Remove teor and Aditya Bharadwaj as ZIP editors
This was missed in the refactor PR.
Assign ZIP 2001 to draft-nuttycom-lockbox-streams
`_config.yml` is deleted as it did not work, indicating that Jinja is
not being used at all for the ZIPs repo rendering.
Assign ZIP number 236 to draft-hopwood-coinbase-balance
Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for zcash-zips-qedit ready!

Name Link
🔨 Latest commit 993b893
🔍 Latest deploy log https://app.netlify.com/sites/zcash-zips-qedit/deploys/66b8ee146d1ab7000877ed95
😎 Deploy Preview https://deploy-preview-58--zcash-zips-qedit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@PaulLaux PaulLaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good overall,

How did we get to 147 * nNotes in zip 230?

@vivek-arte
Copy link
Author

vivek-arte commented Aug 11, 2024

How did we get to 147 * nNotes in zip 230?

We were able to make the value concrete since we explicitly specified the IssueNote type, which is 147 bytes:
image

@vivek-arte vivek-arte merged commit 05766a3 into zsa1 Aug 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.