Non exhaustive IniDefault #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QEDK
approved these changes
Oct 15, 2021
|
This is great! Removes a lot of code duplication which I've always wanted to come to. |
|
@vthib can you rebase this on top of the current master, ty |
Instead of having a derive(Default) on IniDefault, which allows creating a struct with parameters that won't be ok, create an actual Default impl for it. This also duplicates some code from new/new_cs.
This ensures that new fields can be added to it without it being a breaking change.
vthib
force-pushed
the
non-exhaustive-ini-default
branch
from
48604e1
to
4cca50d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark the IniDefault struct as non exhaustive, as discussed here: #19 (comment)
The default values used in
Ini::newandIni::new_csare moved insideIniDefault::default(), otherwise the workflow to create a new IniDefault and update a few values in it is quite cumbersome.