Support conversion of segmentations of multi-frame input series #150
Labels
Comments
|
That's after RSNA, right? |
|
Absolutely! :) I was just going over the code trying to understand why Mint people have segfault (they do not have a complete example to reproduce) and saw that comment. |
|
Well then they should try to provide a complete example for us. Otherwise It's really hard to find the reason for its failing.... |
|
yes, that's what I asked. Our test datasets work fine for them. |
|
Did they ever run dciodvfy on their data? Maybe there is something wrong with their input data? |
|
Same requirement applies to PM |
fedorov
added a commit
to fedorov/dcmqi
that referenced
this issue
Mar 10, 2017
This is an intermediate commit that aims to improve organization of the conversion functionality, motivated by the various standing issues (e.g., QIICR#217, QIICR#192 and QIICR#150) that are difficult to address with the current level of disarray in the code. Some of the ideas are the following: - introduce basic hierarchy of classes to allow reuse of the common functionality between PM and SEG converters (MultiFrameConverter parent for ParametricMapConverter and SegmentationImageConverter) - do not use static functions, instead make better use of converter classes - factor out containers to keep information about ImageVolume and DICOMFrame to simplify conversion and book keeping - improve consistency of naming and code style My plan to proceed with the refactoring is to implement "shadow" functions in the updated classes while keeping the original functions initially, and then phase out the original functions. The current commit is just an intermediate milestone to open this for feedback and keep development history at least somewhat incremental.
fedorov
added a commit
to fedorov/dcmqi
that referenced
this issue
May 5, 2017
This is an intermediate commit that aims to improve organization of the conversion functionality, motivated by the various standing issues (e.g., QIICR#217, QIICR#192 and QIICR#150) that are difficult to address with the current level of disarray in the code. Some of the ideas are the following: - introduce basic hierarchy of classes to allow reuse of the common functionality between PM and SEG converters (MultiFrameConverter parent for ParametricMapConverter and SegmentationImageConverter) - do not use static functions, instead make better use of converter classes - factor out containers to keep information about ImageVolume and DICOMFrame to simplify conversion and book keeping - improve consistency of naming and code style My plan to proceed with the refactoring is to implement "shadow" functions in the updated classes while keeping the original functions initially, and then phase out the original functions. The current commit is just an intermediate milestone to open this for feedback and keep development history at least somewhat incremental.
fedorov
added a commit
to fedorov/dcmqi
that referenced
this issue
May 14, 2017
This is an intermediate commit that aims to improve organization of the conversion functionality, motivated by the various standing issues (e.g., QIICR#217, QIICR#192 and QIICR#150) that are difficult to address with the current level of disarray in the code. Some of the ideas are the following: - introduce basic hierarchy of classes to allow reuse of the common functionality between PM and SEG converters (MultiFrameConverter parent for ParametricMapConverter and SegmentationImageConverter) - do not use static functions, instead make better use of converter classes - factor out containers to keep information about ImageVolume and DICOMFrame to simplify conversion and book keeping - improve consistency of naming and code style My plan to proceed with the refactoring is to implement "shadow" functions in the updated classes while keeping the original functions initially, and then phase out the original functions. The current commit is just an intermediate milestone to open this for feedback and keep development history at least somewhat incremental.
fedorov
added a commit
to fedorov/dcmqi
that referenced
this issue
Jun 22, 2017
This is an intermediate commit that aims to improve organization of the conversion functionality, motivated by the various standing issues (e.g., QIICR#217, QIICR#192 and QIICR#150) that are difficult to address with the current level of disarray in the code. Some of the ideas are the following: - introduce basic hierarchy of classes to allow reuse of the common functionality between PM and SEG converters (MultiFrameConverter parent for ParametricMapConverter and SegmentationImageConverter) - do not use static functions, instead make better use of converter classes - factor out containers to keep information about ImageVolume and DICOMFrame to simplify conversion and book keeping - improve consistency of naming and code style My plan to proceed with the refactoring is to implement "shadow" functions in the updated classes while keeping the original functions initially, and then phase out the original functions. The current commit is just an intermediate milestone to open this for feedback and keep development history at least somewhat incremental.
che85
pushed a commit
to che85/dcmqi
that referenced
this issue
Jun 26, 2017
This is an intermediate commit that aims to improve organization of the conversion functionality, motivated by the various standing issues (e.g., QIICR#217, QIICR#192 and QIICR#150) that are difficult to address with the current level of disarray in the code. Some of the ideas are the following: - introduce basic hierarchy of classes to allow reuse of the common functionality between PM and SEG converters (MultiFrameConverter parent for ParametricMapConverter and SegmentationImageConverter) - do not use static functions, instead make better use of converter classes - factor out containers to keep information about ImageVolume and DICOMFrame to simplify conversion and book keeping - improve consistency of naming and code style My plan to proceed with the refactoring is to implement "shadow" functions in the updated classes while keeping the original functions initially, and then phase out the original functions. The current commit is just an intermediate milestone to open this for feedback and keep development history at least somewhat incremental.
che85
pushed a commit
to che85/dcmqi
that referenced
this issue
Jun 29, 2017
This is an intermediate commit that aims to improve organization of the conversion functionality, motivated by the various standing issues (e.g., QIICR#217, QIICR#192 and QIICR#150) that are difficult to address with the current level of disarray in the code. Some of the ideas are the following: - introduce basic hierarchy of classes to allow reuse of the common functionality between PM and SEG converters (MultiFrameConverter parent for ParametricMapConverter and SegmentationImageConverter) - do not use static functions, instead make better use of converter classes - factor out containers to keep information about ImageVolume and DICOMFrame to simplify conversion and book keeping - improve consistency of naming and code style My plan to proceed with the refactoring is to implement "shadow" functions in the updated classes while keeping the original functions initially, and then phase out the original functions. The current commit is just an intermediate milestone to open this for feedback and keep development history at least somewhat incremental.
fedorov
added a commit
to fedorov/dcmqi
that referenced
this issue
Jun 29, 2017
This is an intermediate commit that aims to improve organization of the conversion functionality, motivated by the various standing issues (e.g., QIICR#217, QIICR#192 and QIICR#150) that are difficult to address with the current level of disarray in the code. Some of the ideas are the following: - introduce basic hierarchy of classes to allow reuse of the common functionality between PM and SEG converters (MultiFrameConverter parent for ParametricMapConverter and SegmentationImageConverter) - do not use static functions, instead make better use of converter classes - factor out containers to keep information about ImageVolume and DICOMFrame to simplify conversion and book keeping - improve consistency of naming and code style My plan to proceed with the refactoring is to implement "shadow" functions in the updated classes while keeping the original functions initially, and then phase out the original functions. The current commit is just an intermediate milestone to open this for feedback and keep development history at least somewhat incremental.
che85
pushed a commit
to che85/dcmqi
that referenced
this issue
Jun 29, 2017
This is an intermediate commit that aims to improve organization of the conversion functionality, motivated by the various standing issues (e.g., QIICR#217, QIICR#192 and QIICR#150) that are difficult to address with the current level of disarray in the code. Some of the ideas are the following: - introduce basic hierarchy of classes to allow reuse of the common functionality between PM and SEG converters (MultiFrameConverter parent for ParametricMapConverter and SegmentationImageConverter) - do not use static functions, instead make better use of converter classes - factor out containers to keep information about ImageVolume and DICOMFrame to simplify conversion and book keeping - improve consistency of naming and code style My plan to proceed with the refactoring is to implement "shadow" functions in the updated classes while keeping the original functions initially, and then phase out the original functions. The current commit is just an intermediate milestone to open this for feedback and keep development history at least somewhat incremental.
fedorov
added a commit
to fedorov/dcmqi
that referenced
this issue
Jun 29, 2017
This is an intermediate commit that aims to improve organization of the conversion functionality, motivated by the various standing issues (e.g., QIICR#217, QIICR#192 and QIICR#150) that are difficult to address with the current level of disarray in the code. Some of the ideas are the following: - introduce basic hierarchy of classes to allow reuse of the common functionality between PM and SEG converters (MultiFrameConverter parent for ParametricMapConverter and SegmentationImageConverter) - do not use static functions, instead make better use of converter classes - factor out containers to keep information about ImageVolume and DICOMFrame to simplify conversion and book keeping - improve consistency of naming and code style My plan to proceed with the refactoring is to implement "shadow" functions in the updated classes while keeping the original functions initially, and then phase out the original functions. The current commit is just an intermediate milestone to open this for feedback and keep development history at least somewhat incremental.
fedorov
added a commit
to fedorov/dcmqi
that referenced
this issue
Jul 5, 2017
This is an intermediate commit that aims to improve organization of the conversion functionality, motivated by the various standing issues (e.g., QIICR#217, QIICR#192 and QIICR#150) that are difficult to address with the current level of disarray in the code. Some of the ideas are the following: - introduce basic hierarchy of classes to allow reuse of the common functionality between PM and SEG converters (MultiFrameConverter parent for ParametricMapConverter and SegmentationImageConverter) - do not use static functions, instead make better use of converter classes - factor out containers to keep information about ImageVolume and DICOMFrame to simplify conversion and book keeping - improve consistency of naming and code style My plan to proceed with the refactoring is to implement "shadow" functions in the updated classes while keeping the original functions initially, and then phase out the original functions. The current commit is just an intermediate milestone to open this for feedback and keep development history at least somewhat incremental.
che85
pushed a commit
to che85/dcmqi
that referenced
this issue
Jul 24, 2017
This is an intermediate commit that aims to improve organization of the conversion functionality, motivated by the various standing issues (e.g., QIICR#217, QIICR#192 and QIICR#150) that are difficult to address with the current level of disarray in the code. Some of the ideas are the following: - introduce basic hierarchy of classes to allow reuse of the common functionality between PM and SEG converters (MultiFrameConverter parent for ParametricMapConverter and SegmentationImageConverter) - do not use static functions, instead make better use of converter classes - factor out containers to keep information about ImageVolume and DICOMFrame to simplify conversion and book keeping - improve consistency of naming and code style My plan to proceed with the refactoring is to implement "shadow" functions in the updated classes while keeping the original functions initially, and then phase out the original functions. The current commit is just an intermediate milestone to open this for feedback and keep development history at least somewhat incremental.
che85
pushed a commit
to che85/dcmqi
that referenced
this issue
Jul 28, 2017
This is an intermediate commit that aims to improve organization of the conversion functionality, motivated by the various standing issues (e.g., QIICR#217, QIICR#192 and QIICR#150) that are difficult to address with the current level of disarray in the code. Some of the ideas are the following: - introduce basic hierarchy of classes to allow reuse of the common functionality between PM and SEG converters (MultiFrameConverter parent for ParametricMapConverter and SegmentationImageConverter) - do not use static functions, instead make better use of converter classes - factor out containers to keep information about ImageVolume and DICOMFrame to simplify conversion and book keeping - improve consistency of naming and code style My plan to proceed with the refactoring is to implement "shadow" functions in the updated classes while keeping the original functions initially, and then phase out the original functions. The current commit is just an intermediate milestone to open this for feedback and keep development history at least somewhat incremental.
fedorov
added a commit
to fedorov/dcmqi
that referenced
this issue
Jul 28, 2017
This is an intermediate commit that aims to improve organization of the conversion functionality, motivated by the various standing issues (e.g., QIICR#217, QIICR#192 and QIICR#150) that are difficult to address with the current level of disarray in the code. Some of the ideas are the following: - introduce basic hierarchy of classes to allow reuse of the common functionality between PM and SEG converters (MultiFrameConverter parent for ParametricMapConverter and SegmentationImageConverter) - do not use static functions, instead make better use of converter classes - factor out containers to keep information about ImageVolume and DICOMFrame to simplify conversion and book keeping - improve consistency of naming and code style My plan to proceed with the refactoring is to implement "shadow" functions in the updated classes while keeping the original functions initially, and then phase out the original functions. The current commit is just an intermediate milestone to open this for feedback and keep development history at least somewhat incremental.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: