Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update runtime env to fix read the docs #4592

Merged
merged 3 commits into from
May 5, 2023

Conversation

walshmm
Copy link
Contributor

@walshmm walshmm commented May 5, 2023

Please review the developer documentation
on the wiki of this project that contains help and requirements.

Proposed changes

urllib3/urllib3#2168 (comment)

It looks like a dependency finally reached EOL, comment in the thread suggests adding this config should resolve the readthedocs builds failing.

What type(s) of changes does this code introduce?

Delete the items that do not apply

Bugfix #4587

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

-- needs to be tested on readthedocs build server --

Checklist

Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.

  • Yes. This PR is up to date with current the current state of 'develop'
  • N/A. Code added or changed in the PR has been clang-formatted
  • N/A. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • N/A. Documentation has been added (if appropriate)

@walshmm walshmm marked this pull request as ready for review May 5, 2023 19:09
@prckent
Copy link
Contributor

prckent commented May 5, 2023

Thanks! It worked. I'll force merge it since it is docs only.

@prckent prckent merged commit eb44f4a into QMCPACK:develop May 5, 2023
@prckent prckent mentioned this pull request Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants