Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Train add #20

Merged
merged 13 commits into from
Jul 30, 2021
Merged

Train add #20

merged 13 commits into from
Jul 30, 2021

Conversation

StephenHausler
Copy link
Contributor

No description provided.

Copy link
Contributor

@Tobias-Fischer Tobias-Fischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, thanks @StephenHausler.

I have a few minor requests (see inline comments) as well as two bigger ones:

  1. It would be great to move the train, test and get_clusters methods to separate files living in patchnetvlad/training_tools. Similarly, move save_checkpoint and humanbytes into patchnetvlad/training_tools/tools.py.

  2. The readme needs extending with describing how the training can be performed.

An added:
It would be nice to add train to

'patchnetvlad-download-models=download_models:download_all_models'],

patchnetvlad/configs/train.ini Outdated Show resolved Hide resolved
patchnetvlad/tools/msls.py Outdated Show resolved Hide resolved
train.py Outdated Show resolved Hide resolved
train.py Outdated Show resolved Hide resolved
@Tobias-Fischer
Copy link
Contributor

Fix #8

Copy link
Contributor

@Tobias-Fischer Tobias-Fischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks! One very minor comment below (probably left from testing) We just need the PCA functionality and this is ready to go in my opinion.

@oravus - would be great if you could have a look, too.

patchnetvlad/training_tools/msls.py Outdated Show resolved Hide resolved
@StephenHausler
Copy link
Contributor Author

All review comments completed, code has been tested and should be ready for merge.

@Tobias-Fischer
Copy link
Contributor

Thanks a lot @StephenHausler - let's merge it in :)

@Tobias-Fischer Tobias-Fischer merged commit 5d8b68f into main Jul 30, 2021
@Tobias-Fischer Tobias-Fischer deleted the train_add branch July 30, 2021 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants