Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support update metadata through MetadataManager #149

Closed
osopardo1 opened this issue Jan 20, 2023 · 1 comment · Fixed by #152
Closed

Support update metadata through MetadataManager #149

osopardo1 opened this issue Jan 20, 2023 · 1 comment · Fixed by #152
Labels
type: enhancement Improvement of existing feature or code

Comments

@osopardo1
Copy link
Member

osopardo1 commented Jan 20, 2023

For implementing Convert To Qbeast (#102 ), we want to be able to add Qbeast Revision's metadata to the new log, without affecting the file entries.

The component in charge of communicating with the log (loading and committing new information) is the MetadataManager. At the current state of the MetadataManager, we can only call the method updateWithTransaction() which is implemented for updating the log with new committed files and table changes.

The idea is to write a new method to update ONLY with table changes. Something like:

  def updateMetadataWithTransaction(tableID: QTableID, schema: DataSchema, append: Boolean)(
      writer: => (TableChanges)): Unit = {}
@osopardo1 osopardo1 added the type: bug Something isn't working label Jan 20, 2023
@osopardo1 osopardo1 changed the title Support update metadata through MetadataManager [Delta] Support update metadata through MetadataManager Jan 20, 2023
@osopardo1 osopardo1 added type: enhancement Improvement of existing feature or code and removed type: bug Something isn't working labels Jan 20, 2023
@osopardo1
Copy link
Member Author

Fixed on #152

@Jiaweihu08 Jiaweihu08 mentioned this issue Jan 27, 2023
5 tasks
@Jiaweihu08 Jiaweihu08 linked a pull request Jan 27, 2023 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing feature or code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant