Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, we are modifying the
QbeastCatalog
to process also writes in Delta (or other formats such Iceberg or Hudi once they're integrated).Type of change
It is an improvement of an existing Catalog feature. Instead of managing two catalogs at the same time, the user would only need to set up one by adding the following configuration to any Spark Application:
--conf spark.sql.catalog.spark_catalog=io.qbeast.spark.internal.sources.catalog.QbeastCatalog
Then, the user can create
qbeast
tables anddelta
tables with either DataFrame API or SQL:The user can also choose to configure them as separate catalogs. But for some integrations (such as
dbt
) it's not recommended.Checklist:
Here is the list of things you should do before submitting this pull request:
How Has This Been Tested? (Optional)
Please describe the tests that you ran to verify your changes.
We add a test in
QbeastCatalogIntegrationTest
in which we try to write asdelta
andqbeast
with the same Catalog.