-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto Indexing #247
Merged
Merged
Auto Indexing #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ipping Add Delta Data Skipping on Staging Area
osopardo1
force-pushed
the
244-autoindexing
branch
from
December 7, 2023 15:44
af3dfd9
to
ea11e90
Compare
Codecov is failing, but test pass and PR is ready to be reviewed. |
alexeiakimov
approved these changes
Dec 14, 2023
fpj
pushed a commit
that referenced
this pull request
Mar 27, 2024
Main added features: - Rollup - Domain-driven appends - Auto-indexing - Multi-block file Additionally, this merge performs the following: - Updates documentation according to the new version. - Removes unnecessary classes (e.g., CubeInfo). - Resolves inconsistencies with the Auto Indexing #247 and CREATE EXTERNAL TABLE without OPTIONS #248 changes. - compact() is no longer necessary, but we are leaving it to avoid additional changes to the staging area. We have issue 294 open to resolve it later. --------- Co-authored-by: Alexey Akimov Co-authored-by: Jiawei Co-authored-by: osopardo1 Co-authored-by: osopardo1 Co-authored-by: SrTangente Co-authored-by: SrTangente Co-authored-by: jiawei
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds new Auto Indexing functionality #244
Type of change
A new feature that enables indexing a DataFrame/Table without specifying the
columnsToIndex
.The feature is not enabled by default. If you want to use it, you should add the necessary configuration.
Code
The idea is to have an
ColumnsToIndexSelector
interface in thecore
project with the following information:MAX_COLUMNS_TO_INDEX
: maximum number of columns to index for this implementation (could be a configurable parameter)selectColumnsToIndex
: this method is called every time we build a new table, only once (if we do not want to update it).Checklist:
Here is the list of things you should do before submitting this pull request:
main-1.0.0
branch (dependent changes have been merged).How Has This Been Tested? (Optional)
This should be tested individually (each AutoIndexer should have unit tests) as well as Integrated with the Spark API (DataFrame reads and writes).