-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Revision metadata and Snapshot #29
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to isolate Revision processes, a new type of snapshot for the Qbeast structures is created. QbeastSnapshot would be only in charge of grouping the different RevisionSnapshots that can be found in the proper delta Snapshot. Analyze, Optimize and Write operations would affect only one RevisionSnapshot, and Read operation needs to query all available RevisionSnapshots.
src/main/scala/io/qbeast/spark/sql/qbeast/RevisionSnapshot.scala
Outdated
Show resolved
Hide resolved
eavilaes
reviewed
Oct 21, 2021
cugni
requested changes
Oct 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should have different revisionID from revisionTimestamp, and make it clear in the API when we refer to a specific revision and when we want all revision happened before of a specific point in time.
src/main/scala/io/qbeast/spark/sql/qbeast/RevisionSnapshot.scala
Outdated
Show resolved
Hide resolved
src/main/scala/io/qbeast/spark/sql/qbeast/RevisionSnapshot.scala
Outdated
Show resolved
Hide resolved
# Conflicts: # src/main/scala/io/qbeast/spark/index/OTreeAlgorithm.scala # src/main/scala/io/qbeast/spark/sql/files/OTreeIndex.scala # src/main/scala/io/qbeast/spark/sql/qbeast/BlockWriter.scala # src/main/scala/io/qbeast/spark/sql/qbeast/QbeastOptimizer.scala # src/main/scala/io/qbeast/spark/sql/qbeast/QbeastSnapshot.scala # src/main/scala/io/qbeast/spark/sql/qbeast/QbeastWriter.scala # src/main/scala/io/qbeast/spark/table/AnalyzeTableCommand.scala # src/main/scala/io/qbeast/spark/table/IndexedTable.scala # src/main/scala/io/qbeast/spark/table/OptimizeTableCommand.scala # src/main/scala/io/qbeast/spark/table/QbeastTable.scala # src/test/scala/io/qbeast/spark/index/NewRevisionTest.scala # src/test/scala/io/qbeast/spark/utils/BlockWriterTest.scala # src/test/scala/io/qbeast/spark/utils/QbeastSnapshotTest.scala
cugni
approved these changes
Oct 26, 2021
Remove duplicated metadata (indexedColumns and desiredCubeSize) and remove noise from method parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #27 and moves the old concept of
SpaceRevision
into a newRevision
case class. ThisRevision
contains more configurable parameters like the desired cube size or the columns used for index:In order to provide
Revision
isolation on Analyze, Optimize and Write operations,RevisionData
contains only the necessary information about a single revision, such as:Revision
information:timestamp
,desiredCubeSize
,indexedColumns
and space transformationsRevision
Weight
values for the singleRevision
For Read operation, we still have to query all available
RevisionData
provided byQbeastSnapshot
.Accordingly, some information is changed in Metadata: