Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 333: Broadcast cube weights during optimization file writing #334

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Issue 333: Broadcast cube weights during optimization file writing #334

merged 1 commit into from
Jul 1, 2024

Conversation

Jiaweihu08
Copy link
Member

Description

Fixes #333.

Type of change

Bug fix.

Checklist:

  • New feature/bug fix has been committed following the Contribution guide.
  • Add logging to the code following the Contribution guide.
  • Add comments to the code (make it easier for the community!).
  • Change the documentation.
  • Add tests.
  • Your branch is updated to the main branch (dependent changes have been merged).

@Jiaweihu08 Jiaweihu08 requested a review from osopardo1 June 13, 2024 10:01
@Jiaweihu08 Jiaweihu08 marked this pull request as ready for review June 28, 2024 14:18
osopardo1
osopardo1 approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@osopardo1 osopardo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@osopardo1 osopardo1 merged commit bb4a999 into Qbeast-io:main Jul 1, 2024
1 check passed
@Jiaweihu08 Jiaweihu08 deleted the 333-reduce-optimization-task-size branch August 1, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osopardo1 osopardo1 osopardo1 approved these changes

Assignees

@Jiaweihu08 Jiaweihu08

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Large Task Deserialization Time during Optimization
2 participants
@Jiaweihu08 @osopardo1