-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #498: Add Hudi Codebase #499
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Just some comments here.
hudi/src/main/scala/io/qbeast/spark/hudi/HudiMetadataWriter.scala
Outdated
Show resolved
Hide resolved
metaClient, | ||
isOverwriteOperation, | ||
updatedConfig, | ||
hasRevisionUpdate = true // Force update the metadata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to study the isolation level of different operations in Hudi. In delta, for instance, metadata updates are Serializable,
and more rigorous checks are done for concurrent writes.
hudi/src/main/scala/io/qbeast/spark/hudi/HudiQbeastFileUtils.scala
Outdated
Show resolved
Hide resolved
writeStatus | ||
} | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the following the same for Delta? If so, we can centralize them somehow to avoid duplication? What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
encodeBlocks is the same, while decodeBlocks is slightly different, although we can probably make both the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see the Hudi support advancing. Congrats!!
I know it's a draft, but I would like to fully understand the changes and try to minimize the issues we already made in the Delta Integration. I've added a few comments (some of them about semanthics, don't worry......)
Description
Type of change
New Hudi table format support
Checklist:
Here is the list of things you should do before submitting this pull request: