Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
MaxWeightEstimation
used inDoublePassOTreeDataAnalyzer.analyze
with a simple Spark SQL codelit(1) / sum(lit(1.0) / col("normalizedWeight")
.The latter is capable of leveraging vectorization, and reduce the time spent on GC.
During a testing, this change reduced the query time from
2.2h
to46mins
, as shown inStage 22
from the following image.Test code:
Cluster from EMR, 3 workers of
c5.xlarge
EC2 instances.