Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Codecov to the CI - Tests coverage #86

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

eavilaes
Copy link
Contributor

@eavilaes eavilaes commented Mar 16, 2022

Codecov eases visibility to check if we are failing to test any part of the code.
We proposed enabling it a long time ago, but we postponed it after the refactoring. I have been doing some tests (eavilaes#5) and I think we can implement it now.

Codecov automatically posts comments with a bot in any PR. I personally find these comments quite annoying, so if you'd like we will be able to remove them in https://app.codecov.io/account/gh/Qbeast-io/yaml (only visible for people belonging to the org.) by adding this line to the global yaml:

comment: false

Note: These comments are currently enabled.


I have also added the CODECOV_TOKEN to the secrets of the repository. Once the tests for this PR have passed, the report should be available in Codecov.

@eavilaes eavilaes self-assigned this Mar 16, 2022
@eavilaes eavilaes marked this pull request as draft March 16, 2022 12:51
@eavilaes
Copy link
Contributor Author

eavilaes commented Mar 16, 2022

PR report available: https://app.codecov.io/gh/Qbeast-io/qbeast-spark/commits (even if it has nothing to compare, as it is the first coverage check)

@eavilaes eavilaes marked this pull request as ready for review March 16, 2022 12:53
@osopardo1 osopardo1 self-requested a review March 16, 2022 16:00
@eavilaes eavilaes merged commit 86c6481 into Qbeast-io:main Mar 17, 2022
@eavilaes eavilaes deleted the codecov-ci branch March 25, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants