fix: vehicle becoming permanently locked #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was able to reproduce a state where the statebag value would not match the client's setting for the vehicle lock state by having two clients both unlocking/locking the same vehicle at the same time. This resulted in a deadlock, where the native state was locked, but the statebag was set to locked, so the client attempted to toggle the state to locked. Since the state was already locked, this resulted in a no-op and the vehicle could not be unlocked.
This PR fixes this issue by checking on the client if the statebag is out of sync with the native and correcting the client to be set to the statebag before doing toggle logic. This is done when the client toggles the locks of the vehicle.