Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: miscl fixes #146

Merged
merged 3 commits into from
Oct 10, 2024
Merged

fix: miscl fixes #146

merged 3 commits into from
Oct 10, 2024

Conversation

Manason
Copy link
Contributor

@Manason Manason commented Oct 9, 2024

Description

  • bridge: fixes an issue where clients would spawn vehicles and immediately give them keys via the plate. Since the vehicle entity isn't known to the server at the time the client gives keys to the plate, the client is never given keys to the expected vehicle. Added a 500ms delay to give time for the server to receive the entity from the client. Also checking for both the untrimmed and trimmed plates just in case to avoid missing an expected vehicle entity.
  • supporting selecting shared job vehicles via class instead of just model
  • send police alert function moved to client config as this will often be replaced by an export to a dispatch resource. There's a good argument to be made that we shouldn't even provide a default implementation since most servers won't use it. (Potential future PR)
  • supporting empty tables in the config to represent that the player shouldn't be allowed to do the skill check or animation (in the case of turning on/off an engine). Previously, although the config stated this was supported, an error would occur.
  • toggle engine key bind wasn't linked to config
  • added checking for toggling engine and then getting out of a vehicle, or getting out of a vehicle and then toggling engine. Previously, this would result in the animation being played even while getting out of the vehicle, which looked goofy. Now, in most scenarios the animation is cancelled.
  • made the aesthetic toggle engine animation delay configurable per animation
  • fixed an issue where any passenger could toggle the engine; now only the driver can.
  • fixed search keys using the lock pick animation instead of the search keys one
  • added ambulance to default shared job keys config and default engine start animations for vehicles, motorcycles, and bikes
  • fixed not being able to lock pick a vehicle to Hotwire it when search keys is disabled for the vehicle (not being able to search shouldn't mean not being able to Hotwire via lock pick)

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

@Manason Manason merged commit 8511649 into main Oct 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants