Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GetVehiclesFromPlate in qb bridge to use CVehicles. #163

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SSnowly
Copy link

@SSnowly SSnowly commented Jan 13, 2025

Description

This Pull Request fixes an issue with the client version of the GetAllVehicles() that makes client have 2 outcomes,
Its not simplified to only collect the vehicles with the GetGamePool('CVehicle') for faster reads. Also compacted the code to not make useless variables.

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

@BerkieBb
Copy link
Contributor

Just an fyi. Doing vehicles[i] everywhere, instead of saving it to a variable and using that, is slower (was benchmarked somewhere in one of the known discords)

@SSnowly
Copy link
Author

SSnowly commented Jan 14, 2025

Just an fyi. Doing vehicles[i] everywhere, instead of saving it to a variable and using that, is slower (was benchmarked somewhere in one of the known discords)

Oh i see, I'll do a commit to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants