Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi workers pre-processing #8

Open
wants to merge 4 commits into
base: sp
Choose a base branch
from

Conversation

trotsky1997
Copy link

What does this PR do?

Fixes # (issue)
#7 (comment)

Before submitting

@HaoshengZou HaoshengZou self-requested a review January 18, 2025 13:07
Copy link
Collaborator

@HaoshengZou HaoshengZou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.
dataset_module[k] = sp_dataset is repeated two times.

)
padded_dataset = dataset.map(pad_sequence, batched=True, **kwargs)
sp_dataset = padded_dataset.map(sp_split, batched=True, **kwargs)
dataset_module[k] = sp_dataset
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just deduplicate this line

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这一行写了两遍重复了,删一行重新commit一下吧

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants