Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use secret for gateway superuser credentials #371

Closed
psschwei opened this issue Mar 27, 2023 · 1 comment · Fixed by #928
Closed

Use secret for gateway superuser credentials #371

psschwei opened this issue Mar 27, 2023 · 1 comment · Fixed by #928
Assignees
Labels
enhancement New feature or request priority: high High priority project: infrastructure Label to identify features related with infrastructure
Milestone

Comments

@psschwei
Copy link
Collaborator

We currently define the gateway credentials for the Helm install in values.yaml.

These are added as environmental variables for the container, but as a result anyone who can view pods in the ray namespace can get access to the superuser credentials:

$ k get po -n ray quantum-serverless-gateway-745bfd7b5f-tz4z4 -o json | jq '.spec.containers[].env'
[
  ...
  {
    "name": "DJANGO_SUPERUSER_USERNAME",
    "value": "admin"
  },
  {
    "name": "DJANGO_SUPERUSER_PASSWORD",
    "value": "passw0rd"
  },
  {
    "name": "DJANGO_SUPERUSER_EMAIL",
    "value": "admin@examplemail.io"
  }
]

Instead of using environmental variables, we should use a more secure method depending on the environment (for example, for Kubernetes we should use secrets)

@Tansito Tansito added the project: infrastructure Label to identify features related with infrastructure label Apr 3, 2023
@IceKhan13 IceKhan13 added the priority: medium Medium priority label Apr 11, 2023
@Tansito Tansito added the priority: high High priority label Aug 30, 2023
@Tansito
Copy link
Member

Tansito commented Aug 30, 2023

Adding high priority to this as @akihikokuroda suggested in #921 . With the current integration that we are doing I think it has a lot of sense to start moving this in parallel.

@Tansito Tansito self-assigned this Aug 31, 2023
@IceKhan13 IceKhan13 added this to the 0.6 milestone Sep 1, 2023
@Tansito Tansito removed the priority: medium Medium priority label Sep 4, 2023
@IceKhan13 IceKhan13 modified the milestones: 0.6, 0.7 Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: high High priority project: infrastructure Label to identify features related with infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants