Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix repository helm configuration #921

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Fix repository helm configuration #921

merged 2 commits into from
Sep 11, 2023

Conversation

Tansito
Copy link
Member

@Tansito Tansito commented Aug 30, 2023 •
edited
Loading

Summary

From #899 we discovered that we had and error in our repository chart configuration. This pull request will fix it.

==> Linting charts/repository
[INFO] Chart.yaml: icon is recommended
[ERROR] templates/: template: repository/templates/deployment.yaml:59:31: executing "repository/templates/deployment.yaml" at <.Values.application.superuser.username>: nil pointer evaluating interface {}.username

Details and comments

  • Fixed a typo in the helm's GHA due to that it's not being fired when there was a change inside charts sub-folders.

@Tansito Tansito added the bug Something isn't working label Aug 30, 2023
akihikokuroda
akihikokuroda reviewed Aug 30, 2023
View reviewed changes
charts/quantum-serverless/charts/repository/values.yaml
@@ -6,6 +6,10 @@ replicaCount: 1

application:
debug: 0
superuser:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need to address this issue. Are we going to bump up to high priority?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should, I'm going to start with the integration with the infrastructure team so I think it has a lot of sense to start working on this.

@Tansito Tansito mentioned this pull request Aug 30, 2023
Closed
akihikokuroda
akihikokuroda approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@akihikokuroda akihikokuroda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tansito Tansito merged commit 190b7dd into main Sep 11, 2023
@Tansito Tansito deleted the fix-repository-helm branch September 11, 2023 07:16
caleb-johnson pushed a commit to caleb-johnson/quantum-serverless that referenced this pull request Sep 27, 2023
@Tansito @caleb-johnson
Fix repository helm configuration (Qiskit#921)
63b6838 
* Fix repository helm configuration

* Fix on-path charts configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akihikokuroda akihikokuroda akihikokuroda approved these changes

@IceKhan13 IceKhan13 IceKhan13 approved these changes

@psschwei psschwei Awaiting requested review from psschwei

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tansito @IceKhan13 @akihikokuroda