-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back class
modifier in front of class signatures
#1287
Comments
Eric-Arellano
changed the title
Add back
Add back May 3, 2024
class
modifier in front of class signatures?class
modifier in front of class signatures
We decided that we do want to do this. We still need to figure out the design. Devs should create a few examples for us to decide:
We should audit if there are any other modifiers we've been dropping. |
Here are the screenshots with an example of how each design would look like. I added the case where we have the modifier w/ bold in and before the code section. Inside the code section examplesOption 1.
|
This was referenced May 9, 2024
github-merge-queue bot
pushed a commit
that referenced
this issue
May 13, 2024
Part of #1287 This PR adds modifiers to the signatures of our API components. We continue removing the modifiers for attributes and properties given that we don't show their signature on the website. This change should be merged after changing the MDX components on IQP to support the new prop.
github-merge-queue bot
pushed a commit
that referenced
this issue
May 13, 2024
Part of #1287 Follow-up of #1337 This PR regenerates the API docs incorporating the changes of #1337. This is split into two PRs to help in the review of the changes to the script and due to the amount of files modified. Here we can find all versions except qiskit 1.0 which was generated in #1337 to review it more exhaustively. This change should be merged after changing the MDX components on IQP to support the new prop.
Closed by @arnaucasau in #1337 🚀 |
frankharkins
pushed a commit
to frankharkins/documentation
that referenced
this issue
Jul 22, 2024
Part of Qiskit#1287 This PR adds modifiers to the signatures of our API components. We continue removing the modifiers for attributes and properties given that we don't show their signature on the website. This change should be merged after changing the MDX components on IQP to support the new prop.
frankharkins
pushed a commit
to frankharkins/documentation
that referenced
this issue
Jul 22, 2024
Part of Qiskit#1287 Follow-up of Qiskit#1337 This PR regenerates the API docs incorporating the changes of Qiskit#1337. This is split into two PRs to help in the review of the changes to the script and due to the amount of files modified. Here we can find all versions except qiskit 1.0 which was generated in Qiskit#1337 to review it more exhaustively. This change should be merged after changing the MDX components on IQP to support the new prop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is how Sphinx renders https://docs.quantum.ibm.com/api/qiskit/dev/circuit#bits-and-registers
Vs us:
documentation/docs/api/qiskit/dev/circuit.mdx
Line 260 in eca9f43
Should we add back the
class
modifier? Should it only be for inline classes, or also dedicated pages like https://docs.quantum.ibm.com/api/qiskit/dev/qiskit.circuit.AnnotatedOperation?If so, should it be italicized? If it should be italicized, should we add a new attribute to the component like
signaturePrefix
?--
What's interesting is some signatures are preserved, like
final class
andstatic
. Why is this?documentation/docs/api/qiskit/circuit_classical.mdx
Line 63 in eca9f43
documentation/docs/api/qiskit-ibm-runtime/qiskit_ibm_runtime.options.Options.mdx
Line 90 in eca9f43
The text was updated successfully, but these errors were encountered: