Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link checker: check external links #305

Closed
Eric-Arellano opened this issue Nov 8, 2023 · 0 comments · Fixed by #337
Closed

Link checker: check external links #305

Eric-Arellano opened this issue Nov 8, 2023 · 0 comments · Fixed by #337
Assignees
@arnaucasau
Labels
infra 🏗️
Milestone
23-11-29 dec release

Comments

@Eric-Arellano
Copy link
Collaborator

See #4 for the design.
@Eric-Arellano Eric-Arellano added this to the 23-11-29 dec release milestone Nov 8, 2023
@Eric-Arellano Eric-Arellano mentioned this issue Nov 8, 2023
Closed
@Eric-Arellano Eric-Arellano moved this to In Progress in Docs Planning Nov 9, 2023
@arnaucasau arnaucasau mentioned this issue Nov 12, 2023
Merged
arnaucasau added a commit that referenced this issue Nov 14, 2023
@arnaucasau @Eric-Arellano
Link checker: external links' validation (#337)
c0470de 
### Summary

This PR adds support for the validation of external links using the link
checker. Tests for the validation have been included, and the CI test
has been extended to validate external links.

By default, the link checker only validates internal links, but we can
activate the external links validation using:

`npm run check:links -- --external`

Closes #305

---------

Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Docs Planning Nov 14, 2023
frankharkins pushed a commit to frankharkins/documentation that referenced this issue Jul 22, 2024
@arnaucasau @Eric-Arellano
Link checker: external links' validation (Qiskit#337)
795fc2f 
### Summary

This PR adds support for the validation of external links using the link
checker. Tests for the validation have been included, and the CI test
has been extended to validate external links.

By default, the link checker only validates internal links, but we can
activate the external links validation using:

`npm run check:links -- --external`

Closes Qiskit#305

---------

Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arnaucasau arnaucasau

Labels
infra 🏗️
Projects
Docs Planning
Archived in project
Milestone
23-11-29 dec release
Development

Successfully merging a pull request may close this issue.

Link checker: external links' validation arnaucasau/documentation
2 participants
@Eric-Arellano @arnaucasau