Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert changes from issue #190 after server changes are made #582

Closed
Tracked by #1073
mriedem opened this issue Jan 3, 2024 · 3 comments · Fixed by #783
Closed
Tracked by #1073

Revert changes from issue #190 after server changes are made #582

mriedem opened this issue Jan 3, 2024 · 3 comments · Fixed by #783
Assignees
Labels
content request request for new content to be added content 📄 new ✨

Comments

@mriedem
Copy link
Collaborator

mriedem commented Jan 3, 2024

URL, if applicable

https://docs.quantum.ibm.com/run/run-jobs-in-session#open-a-session for this part:

If the first session job is canceled, subsequent session jobs will all fail.

https://docs.quantum.ibm.com/run/run-jobs-in-session#close-a-session for this part:

Note that when you cancel the root job in the session (the job which has the same ID as the session), the session closes and fails any remaining queued jobs in the session.

Describe the new content you are requesting.

The pay-go cloud channel and quantum (IQP) channel server side behaviors are going to change such that the docs changes for issue #190 can be reverted once the server side changes are in production for both channels.

With epic Decouple session from root job the API is going to support explicitly creating a session rather than implicitly with the first job in the session such that the first (root) job and session have the same ID. With that decoupling we'll be able to revert the previous change where we would close the session and fail any remaining queued jobs, so we won't need those notes in the docs anymore.

I'm not sure if a qiskit-ibm-runtime issue exists for this yet, but eventually that code will need to change to create the session explicitly for batch mode support.

This issue is a placeholder to make sure we don't forget about the docs updates, but again don't make these until we've confirmed that the server sides changes in both channels is in production.

If this new content request is accepted, do you want to write the content?

I can help the team by providing enough information to write the material

@mriedem
Copy link
Collaborator Author

mriedem commented Mar 21, 2024

@abbycross @beckykd This is no longer blocked.

@beckykd
Copy link
Collaborator

beckykd commented Mar 21, 2024

@abbycross, I'm in the process of updating all of the session docs right now, so I can just make this change with that PR.

@beckykd
Copy link
Collaborator

beckykd commented Mar 21, 2024

#783

@beckykd beckykd mentioned this issue Mar 21, 2024
1 task
@javabster javabster linked a pull request Mar 22, 2024 that will close this issue
1 task
@abbycross abbycross removed their assignment Apr 3, 2024
@javabster javabster moved this from Todo to In Progress in Docs Planning Apr 26, 2024
github-merge-queue bot pushed a commit that referenced this issue Apr 29, 2024
Closes #595  
Closes #1041 
Closes #582 
Closes #780
Closes #582
Closes #1156 
Closes #577 
Closes #576 

- [x] Add text about job splitting, such as "If you split your workload
into multiple jobs and run them in Batch mode, you can get results from
individual jobs. You can, for example, decide to cancel the rest of the
jobs if the earlier job results don't meet your expectations. If one of
the jobs fail, you can also re-submit just that one instead of
re-running the entire workload."

There are several new and existing topics that are impacted:

- This documentation section has several topics about execution modes:
https://qiskit-docs-preview-pr-783.1799mxdls7qz.us-south.codeengine.appdomain.cloud/run/execution-modes
- This migration guide is new:
https://qiskit-docs-preview-pr-783.1799mxdls7qz.us-south.codeengine.appdomain.cloud/api/migration-guides/sessions

---------

Co-authored-by: Ashley Silva <asarver1@gmail.com>
Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>
Co-authored-by: abbycross <across@us.ibm.com>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Docs Planning Apr 29, 2024
frankharkins pushed a commit to frankharkins/documentation that referenced this issue Jul 22, 2024
Closes Qiskit#595  
Closes Qiskit#1041 
Closes Qiskit#582 
Closes Qiskit#780
Closes Qiskit#582
Closes Qiskit#1156 
Closes Qiskit#577 
Closes Qiskit#576 

- [x] Add text about job splitting, such as "If you split your workload
into multiple jobs and run them in Batch mode, you can get results from
individual jobs. You can, for example, decide to cancel the rest of the
jobs if the earlier job results don't meet your expectations. If one of
the jobs fail, you can also re-submit just that one instead of
re-running the entire workload."

There are several new and existing topics that are impacted:

- This documentation section has several topics about execution modes:
https://qiskit-docs-preview-pr-783.1799mxdls7qz.us-south.codeengine.appdomain.cloud/run/execution-modes
- This migration guide is new:
https://qiskit-docs-preview-pr-783.1799mxdls7qz.us-south.codeengine.appdomain.cloud/api/migration-guides/sessions

---------

Co-authored-by: Ashley Silva <asarver1@gmail.com>
Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>
Co-authored-by: abbycross <across@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content request request for new content to be added content 📄 new ✨
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants