After Aer .14 is released, remove approximation=true from relevant pages #1020
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
One or more of the the following people are requested to review this:
|
| @@ -151,7 +151,7 @@ This guide describes these common configurations for algorithms that determine w | |||
| from qiskit_aer.primitives import Sampler, Estimator | |||
|
|
|||
| sampler = Sampler(run_options={"approximation": True, "shots": None}) | |||
There was a problem hiding this comment.
@kevinsung the change is only for Estimator, not Sampler, correct? Should I leave this line as-is?
There was a problem hiding this comment.
As far as I know, "approximation" is not a valid run option, so I think it can be removed immediately from all examples of Sampler and Estimator. See Qiskit/qiskit-aer#2083 though.
#319 Refers to passing approximation=True directly to the initializer of Estimator, as in those pages in the verify section.
I am confused because in the Qiskit SDK .10 release notes, it mentions Aer 0.2? EDITED TO ADD -- Eric clarified for me the difference between Aer when it was part of the metapackage, and Aer now. |
abbycross
changed the title
abbycross
changed the title
|
Ready for review (need to debug the failing notebook check too) |
Co-authored-by: Frank Harkins <frankharkins@hotmail.co.uk>
Co-authored-by: Frank Harkins <frankharkins@hotmail.co.uk>
Co-authored-by: Frank Harkins <frankharkins@hotmail.co.uk>
Co-authored-by: Frank Harkins <frankharkins@hotmail.co.uk>
Co-authored-by: Frank Harkins <frankharkins@hotmail.co.uk>
|
Thanks for catching those @frankharkins ! |
…ges (Qiskit#1020) Closes Qiskit#319 --------- Co-authored-by: Frank Harkins <frankharkins@hotmail.co.uk>
Closes #319