Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API generation script uses MDX components #1026
API generation script uses MDX components #1026
Changes from 8 commits
59bce17
06b72cb
66227d1
2dba29e
f50931e
902f7ea
d8a2b95
096e98b
388accb
e662550
ee08ec2
f966534
ce842a6
e91d5fd
4039c0c
4c1fe88
2ead845
a728ebb
f7ed13f
aceb889
2d7c177
d3b8195
8ed2097
03e2fe1
7ceb9ff
3c46a3b
92b29d6
5b1c16d
7f67604
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This name is a bit confusing. Maybe call it
extraSignatures: ComponentProps[]
? And call the functionaddExtraSignatures
ormergeExtraSignatures
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right. I changed for
extraRawSignatures
following the same advice as inrawSignatures
👍There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was my first idea, but the filter doesn't work very well with undefined or nulls. The return value is still
string | undefined
afterward.Nonetheless, I like the idea, and I think we can make it more compact with flatMap: