Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update batch example #1129

Merged
merged 4 commits into from
Apr 5, 2024
Merged

Update batch example #1129

merged 4 commits into from
Apr 5, 2024

Conversation

beckykd
Copy link
Collaborator

@beckykd beckykd commented Apr 4, 2024

closes #1128

@beckykd beckykd requested review from Eric-Arellano and jyu00 April 4, 2024 18:40
@qiskit-bot
Copy link
Contributor

Thanks for contributing to Qiskit documentation!

Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌

One or more of the the following people are requested to review this:

Copy link
Collaborator

@jyu00 jyu00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code needs to be updated, but otherwise looks good

docs/run/run-jobs-batch.mdx Outdated Show resolved Hide resolved

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>
Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Becky

docs/run/run-jobs-batch.mdx Show resolved Hide resolved
docs/run/run-jobs-batch.mdx Outdated Show resolved Hide resolved
Copy link
Collaborator

@jyu00 jyu00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking Eric's suggestions but fix the syntax

docs/run/run-jobs-batch.mdx Show resolved Hide resolved
docs/run/run-jobs-batch.mdx Outdated Show resolved Hide resolved
beckykd and others added 2 commits April 5, 2024 11:16

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>
@beckykd beckykd added this pull request to the merge queue Apr 5, 2024
Merged via the queue into main with commit acd422e Apr 5, 2024
4 checks passed
@beckykd beckykd deleted the update-batch-example branch April 5, 2024 16:25
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
closes Qiskit#1128

---------

Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Batch mode docs are using V1 primitives
4 participants