Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runtime options table #1188

Merged
merged 6 commits into from
Apr 29, 2024
Merged

Add runtime options table #1188

merged 6 commits into from
Apr 29, 2024

Conversation

beckykd
Copy link
Collaborator

@beckykd beckykd commented Apr 16, 2024

closes #1124

@beckykd beckykd requested a review from jyu00 April 16, 2024 20:52
@qiskit-bot
Copy link
Contributor

Thanks for contributing to Qiskit documentation!

Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌

One or more of the the following people are requested to review this:

docs/run/advanced-runtime-options.mdx Outdated Show resolved Hide resolved
docs/run/advanced-runtime-options.mdx Outdated Show resolved Hide resolved
Copy link
Collaborator

@jyu00 jyu00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Although I'd change the last sentence in the first paragraph to point to this table instead of the API reference, since the complaint was the API reference was hard to read. E.g. change

"Other options are grouped into different categories, such as execution. See all the available options in the API reference"

to

"Other options are grouped into different categories, such as execution. See this table for different categories."

Copy link
Collaborator

@jyu00 jyu00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@beckykd beckykd added this pull request to the merge queue Apr 29, 2024
Merged via the queue into main with commit 2219155 Apr 29, 2024
4 checks passed
@beckykd beckykd deleted the options-table branch April 29, 2024 18:04
Copy link
Collaborator

@abbycross abbycross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestions!

docs/run/advanced-runtime-options.mdx Show resolved Hide resolved
docs/run/advanced-runtime-options.mdx Show resolved Hide resolved
docs/run/advanced-runtime-options.mdx Show resolved Hide resolved
docs/run/advanced-runtime-options.mdx Show resolved Hide resolved
docs/run/advanced-runtime-options.mdx Show resolved Hide resolved
beckykd added a commit that referenced this pull request Apr 29, 2024
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add options table for V2 primitives
5 participants