-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use asyncio to parallelize notebook testing #1201
Conversation
While interesting, I'd opt for readability / reliability over performance here. As long as the jobs are submitted immediately it should drastically help with the cron jobs. Same for the contention issue; I'm not too worried if we're not using CPU 100% efficiently, the main thing is getting the jobs out ASAP rather than in sequence. To check, run with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! All looks good to me, I also tested the script locally, and worked well!
An alternative to Qiskit#1181. This should help when executing many notebooks that submit jobs as they'll all submit their jobs immediately and begin queueing in parallel. --------- Co-authored-by: Frank Harkins <frankharkins@hotmail.co.uk>
An alternative to #1181. This should help when executing many notebooks that submit jobs as they'll all submit their jobs immediately and begin queueing in parallel.