Make notebook tester into package #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…H/packagify-nb-tester
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
| raise ValueError( | ||
| f"Couldn't read config from {path}; check it exists and the" | ||
| " entries are correct." | ||
| ) from err |
There was a problem hiding this comment.
nice use of from err!
Eric-Arellano
approved these changes
Apr 24, 2024
frankharkins
added a commit
to frankharkins/documentation
that referenced
this pull request
Jul 22, 2024
Makes the notebook tester into an installable package so we can re-use it in other repos. Main changes are: * Adding `pyproject.toml` and moving script to `qiskit_docs_notebook_tester/__init__.py` * Moving the lists of notebooks to a config file * Splitting the requirements needed for running the code in the notebooks form those neeed by the testing script itself The interface via `tox` should be unaffected. --------- Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the notebook tester into an installable package so we can re-use it in other repos.
Main changes are:
pyproject.tomland moving script toqiskit_docs_notebook_tester/__init__.pyThe interface via
toxshould be unaffected.