Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tabs from "Plot quantum states" #1218

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Remove tabs from "Plot quantum states" #1218

merged 1 commit into from
Apr 22, 2024

Conversation

frankharkins
Copy link
Member

This page wrapped code blocks in <TabItem> tags to include them in the tab component. This looks nice but unfortunately relied on some implementation details of how the notebook is converted to the web page, which is something we want to avoid.

This PR removes the tabs and uses headings instead to unblock publishing the page while we work on a more robust solution.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Eric-Arellano Eric-Arellano added this pull request to the merge queue Apr 22, 2024
Merged via the queue into main with commit fb74dd8 Apr 22, 2024
5 checks passed
@Eric-Arellano Eric-Arellano deleted the FH/de-tabify branch April 22, 2024 17:07
github-merge-queue bot pushed a commit that referenced this pull request Apr 23, 2024
I missed this in #1218; removing for now while we work on a solution.
frankharkins added a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
This page wrapped code blocks in `<TabItem>` tags to include them in the
tab component. This looks nice but unfortunately relied on some
implementation details of how the notebook is converted to the web page,
which is something we want to avoid.

This PR removes the tabs and uses headings instead to unblock publishing
the page while we work on a more robust solution.
frankharkins added a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
I missed this in Qiskit#1218; removing for now while we work on a solution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants