Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tutorial deployment process #1222

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Conversation

frankharkins
Copy link
Member

@frankharkins frankharkins commented Apr 23, 2024

I thought I'd tested this in #1154 but I actually only tested the uploader test workflow. I'd forgotten to pass the environment from the input to the job.

Something which wasn't my fault is that some tutorial UUIDs seem to have changed, I'm not sure why this is but am investigating.

With the new UUIDs, the workflow is working (see run).

@frankharkins frankharkins temporarily deployed to Learning platform (staging) April 23, 2024 09:00 — with GitHub Actions Inactive
@frankharkins frankharkins temporarily deployed to Learning platform (staging) April 23, 2024 09:48 — with GitHub Actions Inactive
Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Spooky with the UUIDs. Does changing the metadata of a tutorial like its title impact anything? If you don't already, you could create a new fake tutorial to test things out.

@frankharkins
Copy link
Member Author

That's a good idea. I tried changing the title of the tutorial we use to test the uploader but that didn't do anything :/

@frankharkins frankharkins marked this pull request as ready for review April 23, 2024 16:06
@frankharkins
Copy link
Member Author

Spoke to the team and they confirmed UUIDs shouldn't change. I'm not sure what went wrong here (possibly still human error on my part), but I think it's OK to merge for now and we can handle any future problems as they occur.

@frankharkins frankharkins added this pull request to the merge queue Apr 23, 2024
Merged via the queue into main with commit 4adca7b Apr 23, 2024
3 checks passed
@frankharkins frankharkins deleted the FH/fix-tutorial-deployment branch April 23, 2024 16:28
frankharkins added a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
I thought I'd tested this in Qiskit#1154 but I actually only tested the
uploader test workflow. I'd forgotten to pass the environment from the
input to the job.

Something which wasn't my fault is that some tutorial UUIDs seem to have
changed, I'm not sure why this is but am investigating.

With the new UUIDs, the workflow is working ([see
run](https://github.com/Qiskit/documentation/actions/runs/8798350887/job/24145159885)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants