Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename tutorial notebooks to be unique #1224

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Conversation

Eric-Arellano
Copy link
Collaborator

We can name the notebook file what we want. So, we were using notebook.ipynb to not repeat the tutorial name both in its parent folder and the notebook file.

But repeating notebook.ipynb has been annoying. It makes it harder in your IDE to know which file is which. It also makes the CI artifact upload less useful because the artifact only has the file names without the parent folder name.

Copy link
Collaborator

@abbycross abbycross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Eric-Arellano Eric-Arellano added this pull request to the merge queue Apr 23, 2024
Merged via the queue into main with commit 0f2bbcf Apr 23, 2024
3 checks passed
@Eric-Arellano Eric-Arellano deleted the EA/rename-notebooks branch April 23, 2024 20:12
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
We can name the notebook file what we want. So, we were using
`notebook.ipynb` to not repeat the tutorial name both in its parent
folder and the notebook file.

But repeating `notebook.ipynb` has been annoying. It makes it harder in
your IDE to know which file is which. It also makes the CI artifact
upload less useful because the artifact only has the file names without
the parent folder name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants