Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the extra = character from the attribute's default value prop #1233

Merged
merged 43 commits into from
Apr 29, 2024

Conversation

arnaucasau
Copy link
Collaborator

@arnaucasau arnaucasau commented Apr 24, 2024

Part of #1216
The attributes will be redesigned, and we won't need to store the = character as part of the default value prop. This character can be added from the react component if it's needed again in the future, similar to how we are already using the type hints.

@arnaucasau arnaucasau marked this pull request as ready for review April 29, 2024 12:13
@arnaucasau arnaucasau changed the title [do not merge] Remove the extra = character from the attribute's default value prop Remove the extra = character from the attribute's default value prop Apr 29, 2024
@qiskit-bot
Copy link
Contributor

Thanks for contributing to Qiskit documentation!

Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌

@arnaucasau arnaucasau added this pull request to the merge queue Apr 29, 2024
Merged via the queue into Qiskit:main with commit 0a03372 Apr 29, 2024
5 checks passed
@arnaucasau arnaucasau deleted the AC/remove-equal-char-attributes branch April 29, 2024 16:42
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Qiskit#1233)

Part of Qiskit#1216
The attributes will be redesigned, and we won't need to store the `=`
character as part of the default value prop. This character can be added
from the react component if it's needed again in the future, similar to
how we are already using the type hints.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants