-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the extra =
character from the attribute's default value prop
#1233
Merged
arnaucasau
merged 43 commits into
Qiskit:main
from
arnaucasau:AC/remove-equal-char-attributes
Apr 29, 2024
Merged
Remove the extra =
character from the attribute's default value prop
#1233
arnaucasau
merged 43 commits into
Qiskit:main
from
arnaucasau:AC/remove-equal-char-attributes
Apr 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
approved these changes
Apr 24, 2024
arnaucasau
changed the title
[do not merge] Remove the extra
Remove the extra Apr 29, 2024
=
character from the attribute's default value prop=
character from the attribute's default value prop
Thanks for contributing to Qiskit documentation! Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌 |
frankharkins
pushed a commit
to frankharkins/documentation
that referenced
this pull request
Jul 22, 2024
Qiskit#1233) Part of Qiskit#1216 The attributes will be redesigned, and we won't need to store the `=` character as part of the default value prop. This character can be added from the react component if it's needed again in the future, similar to how we are already using the type hints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1216
The attributes will be redesigned, and we won't need to store the
=
character as part of the default value prop. This character can be added from the react component if it's needed again in the future, similar to how we are already using the type hints.