Minor improvements to "Hello world" #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
frankharkins
commented
Apr 24, 2024
•
frankharkins
commented
- Adds some tests to ensure hardware outputs make sense. The most important checks that the graph in Step 4. Analyze the results looks correct, as the current one doesn't match the description. (compare to new graph).
- Also makes some minor tweaks I noticed while looking for good places for tests.
- Re-run notebook
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…H/hello-world-tests
The `Pauli` class does not have an `apply_layout` method, and it's not immediately clear to me how to fix it. The notebook ran using `SparsePauliOp` so I'm sticking with that. Since `SparsePauliOp` doesn't have a `to_label` method, I'm sticking to the list comprehension rather than defining them all as separate variables.
…H/hello-world-tests
…H/hello-world-tests
|
One or more of the the following people are requested to review this: |
|
Finally managed to execute this; ready for review now 🙂 |
frankharkins
added a commit
to frankharkins/documentation
that referenced
this pull request
Jul 22, 2024
* Adds some tests to ensure hardware outputs make sense. The most important checks that the graph in [Step 4. Analyze the results](https://docs.quantum.ibm.com/start/hello-world#step-4-analyze-the-results) looks correct, as the current one doesn't match the description. (compare to [new graph](https://qiskit-docs-preview-pr-1234.1799mxdls7qz.us-south.codeengine.appdomain.cloud/start/hello-world#step-4-analyze-the-results)). * Also makes some minor tweaks I noticed while looking for good places for tests. * Re-run notebook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.