Refactor generateToc tests to use normal project structure #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
commented
May 1, 2024
| ...DEFAULT_ARGS, | ||
| }, | ||
| ]); | ||
|
|
||
| expect(toc).toMatchInlineSnapshot(` |
There was a problem hiding this comment.
Only the page names and URLs changed in this diff
Comment on lines
+185
to
+189
| { | ||
| moduleId: "my_quantum_project.another", | ||
| title: "dedicated module", | ||
| kind: "module", | ||
| }, |
There was a problem hiding this comment.
This is a new test because once we have #1249, we couldn't be confident that putting the API index page in the title came from our grouping code rather than the new ensureIndexPage().
| isReleaseNotes: true, | ||
| }, | ||
| ], | ||
| ); | ||
|
|
||
| expect(toc).toMatchInlineSnapshot(` |
There was a problem hiding this comment.
No changes made other than URLs and page titles
frankharkins
pushed a commit
to frankharkins/documentation
that referenced
this pull request
Jul 22, 2024
This is to unblock Qiskit#1249. We now use the project folder that `Pkg.mock().outputDir()` would use. This also removes inline snapshots. They can't be updated via `npm test -- -u` due to Prettier, so it's more helpful to use a normal `expect().toEqual()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to unblock #1249. We now use the project folder that
Pkg.mock().outputDir()would use.This also removes inline snapshots. They can't be updated via
npm test -- -udue to Prettier, so it's more helpful to use a normalexpect().toEqual().