Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add index page to left ToC for Runtime and Provider #1269

Merged
merged 17 commits into from
May 2, 2024
Merged

Add index page to left ToC for Runtime and Provider #1269

merged 17 commits into from
May 2, 2024

Conversation

Eric-Arellano
Copy link
Collaborator

@Eric-Arellano Eric-Arellano commented May 1, 2024 •
edited
Loading

Closes #1249.

Some of the reasons we decided to make this change:

  1. Consistency with Qiskit SDK
  2. It's useful to show the currently selected page in the left ToC when you land on the index

Before:

Screenshot 2024-05-01 at 11 31 00 AM

After:

Screenshot 2024-05-01 at 11 32 41 AM

Eric-Arellano added 17 commits May 1, 2024 11:28
@Eric-Arellano Eric-Arellano requested a review from frankharkins May 1, 2024 15:29
frankharkins
frankharkins approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@frankharkins frankharkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean change, thanks!

@Eric-Arellano Eric-Arellano added this pull request to the merge queue May 2, 2024
Merged via the queue into main with commit 599efd7 May 2, 2024
5 checks passed
@Eric-Arellano Eric-Arellano deleted the EA/ensure-index branch May 2, 2024 14:28
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
@Eric-Arellano
Add index page to left ToC for Runtime and Provider (Qiskit#1269)
e701cac 
Closes Qiskit#1249. 

Some of the reasons we decided to make this change:

1. Consistency with Qiskit SDK
2. It's useful to show the currently selected page in the left ToC when
you land on the index

Before:

<img width="272" alt="Screenshot 2024-05-01 at 11 31 00 AM"
src="https://github.com/Qiskit/documentation/assets/14852634/b80da918-526f-45ff-bd96-49a5585b3fbf">

After:

<img width="266" alt="Screenshot 2024-05-01 at 11 32 41 AM"
src="https://github.com/Qiskit/documentation/assets/14852634/396fa470-68a8-470d-b9d4-4f4f5c08cec6">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankharkins frankharkins frankharkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Docs Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose index page in left ToC for Runtime and Provider
2 participants
@Eric-Arellano @frankharkins