Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "warning suppression" code #1307

Merged
merged 16 commits into from
May 10, 2024
Merged

Remove "warning suppression" code #1307

merged 16 commits into from
May 10, 2024

Conversation

beckykd
Copy link
Collaborator

@beckykd beckykd commented May 6, 2024

Closes #1279
Closes #1331

I removed the "ignore warning" code from all relevant tutorials (in addition to VQE and CHSH) and ran them all locally on simulators to make sure we aren't getting warnings. I also added Requirements sections to VQE and CHSH.

Working on re-generating the output for CHSH since it currently runs on a 27Q system, but I'm in the queue for 16 hrs.

@beckykd beckykd self-assigned this May 6, 2024
@qiskit-bot
Copy link
Contributor

Thanks for contributing to Qiskit documentation!

Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@beckykd
Copy link
Collaborator Author

beckykd commented May 6, 2024

the tutorial "Submitting transpiled circuits" needs to be updated to V2.

@beckykd
Copy link
Collaborator Author

beckykd commented May 7, 2024

@Eric-Arellano and @frankharkins, this should be ready for review, but one of the cells in VQE is timing out in CI. Can someone help me address that so it can be completed? It runs fine on my local simulator, so it shouldn't be timing out.

github-merge-queue bot pushed a commit that referenced this pull request May 10, 2024
Running notebooks with the `FakeKyoto` backend was occassionally taking
a very long time (see
#1307 (comment)).
We believe this is due to some notebooks taking advantage of the large
number of qubits it supports.

This PR switches to Qiskit's `GenericBackendV2`. This should be much
faster and gives us more fine-grained control over the test backend
properties.
Copy link
Member

@frankharkins frankharkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@beckykd beckykd added this pull request to the merge queue May 10, 2024
Merged via the queue into main with commit 8a70b8e May 10, 2024
3 checks passed
@beckykd beckykd deleted the remove-warning-suppression branch May 10, 2024 18:54
@HuangJunye
Copy link
Contributor

@beckykd @frankharkins Thanks for fixing #1331. The callback section can be removed entirely since it is no longer needed.

frankharkins added a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Running notebooks with the `FakeKyoto` backend was occassionally taking
a very long time (see
Qiskit#1307 (comment)).
We believe this is due to some notebooks taking advantage of the large
number of qubits it supports.

This PR switches to Qiskit's `GenericBackendV2`. This should be much
faster and gives us more fine-grained control over the test backend
properties.
frankharkins added a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Closes Qiskit#1279 
Closes Qiskit#1331 

I removed the "ignore warning" code from all relevant tutorials (in
addition to VQE and CHSH) and ran them all locally on simulators to make
sure we aren't getting warnings. I also added Requirements sections to
VQE and CHSH.

Working on re-generating the output for CHSH since it currently runs on
a 27Q system, but I'm in the queue for 16 hrs.

---------

Co-authored-by: Frank Harkins <frankharkins@hotmail.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

VQE tutorial has unnecessary recalculation of the cost in callback Fix issues in CHSH and VQE tutorials
5 participants