Refactor nb-tester config and args #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slight behaviour change as we'll now print excluded notebooks. We didn't do this initially to avoid noise, but since we only exclude one notebook, I think it's better to be verbose.
Slight behaviour change in the printed messages.
Eric-Arellano
approved these changes
May 13, 2024
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
frankharkins
added a commit
to frankharkins/documentation
that referenced
this pull request
Jul 22, 2024
This script now has some non-trivial logic to do with skipping, mocking, writing, etc. This refactor combines the `Config` and args objects so we have a single point of decision making. You may find it easier to review each commit separately. This is prework for Qiskit#1319. --------- Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script now has some non-trivial logic to do with skipping, mocking, writing, etc. This refactor combines the
Configand args objects so we have a single point of decision making. You may find it easier to review each commit separately.This is prework for #1319.