Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve transpile index page #1413

Merged
merged 6 commits into from
Jun 4, 2024
Merged

Conversation

beckykd
Copy link
Collaborator

@beckykd beckykd commented May 20, 2024

Closes #910

Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of these changes look safe to go live right now? What in particular can't go live yet?

@Eric-Arellano Eric-Arellano changed the title [Do not merge - patterns] Remove workflow phrasing Improve transpile index page Jun 3, 2024
Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abbycross and I agree that this is safe to merge now. Perhaps we will need follow up improvements for Patterns that are not yet safe to merge, but these changes look good.

docs/transpile/index.mdx Outdated Show resolved Hide resolved
docs/transpile/index.mdx Show resolved Hide resolved
docs/transpile/index.mdx Outdated Show resolved Hide resolved
docs/transpile/index.mdx Outdated Show resolved Hide resolved
docs/transpile/index.mdx Show resolved Hide resolved
@Eric-Arellano Eric-Arellano marked this pull request as ready for review June 3, 2024 16:41
@qiskit-bot
Copy link
Contributor

Thanks for contributing to Qiskit documentation!

Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌

One or more of the following people are relevant to this code:

Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
abbycross and others added 2 commits June 3, 2024 12:57
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
@beckykd
Copy link
Collaborator Author

beckykd commented Jun 4, 2024

A lot of these changes look safe to go live right now? What in particular can't go live yet?

IDK - it was in the issue that it shouldn't go live until the refactoring is done, but if you and @abbycross think it's fine to go live now, I'll do that.

@beckykd beckykd added this pull request to the merge queue Jun 4, 2024
Merged via the queue into main with commit 84c74be Jun 4, 2024
4 checks passed
@beckykd beckykd deleted the refactor-to-remove-workflow-phrasing branch June 4, 2024 21:13
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Closes Qiskit#910

---------

Co-authored-by: abbycross <across@us.ibm.com>
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[ REFACTOR ] transpile/introduction page to remove workflow phrasing
4 participants