Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spinner from learning uploader #1415

Merged
merged 2 commits into from
May 21, 2024
Merged

Conversation

frankharkins
Copy link
Member

@frankharkins frankharkins commented May 21, 2024

Small refactor before #1390.

The spinner was fun when the tool was primarily used locally, but now it's annoying in CI and is an extra dependency. See an example of the new behaviour in the test.

@frankharkins frankharkins temporarily deployed to Learning platform (staging) May 21, 2024 11:22 — with GitHub Actions Inactive
Isn't really necessary and has potential to be buggy
@frankharkins frankharkins temporarily deployed to Learning platform (staging) May 21, 2024 11:25 — with GitHub Actions Inactive
@frankharkins frankharkins marked this pull request as ready for review May 21, 2024 11:28
@frankharkins frankharkins added this pull request to the merge queue May 21, 2024
Merged via the queue into main with commit a6d5c73 May 21, 2024
4 checks passed
@frankharkins frankharkins deleted the FH/learning-uploader-yaspin branch May 21, 2024 13:41
frankharkins added a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Small refactor before Qiskit#1390.

The spinner was fun when the tool was primarily used locally, but now
it's annoying in CI and is an extra dependency. See an example of the
new behaviour in the
[test](https://github.com/Qiskit/documentation/actions/runs/9173882338/job/25223510491#step:5:102).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants