Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use hellinger_fidelity function from qiskit #1426

Merged
merged 1 commit into from
May 28, 2024
Merged

use hellinger_fidelity function from qiskit #1426

merged 1 commit into from
May 28, 2024

Conversation

kevinsung
Copy link
Collaborator

No description provided.

@qiskit-bot
Copy link
Contributor

One or more of the following people are relevant to this code:

  • @kevinsung

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it okay the outputs didn't change at all?

@kevinsung
Copy link
Collaborator Author

kevinsung commented May 28, 2024

Is it okay the outputs didn't change at all?

I decided not to re-run the notebook because other outputs would change, and updating the notebook is a separate issue #1025. The output of the cell affected by this PR is unchanged up to 8 decimal places.

@kevinsung kevinsung added this pull request to the merge queue May 28, 2024
Merged via the queue into main with commit 9d8fd5a May 28, 2024
5 checks passed
@kevinsung kevinsung deleted the kjs/hellinger branch May 28, 2024 15:36
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants