Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add three new pages to docs migration #1494

Merged
merged 5 commits into from
Jun 18, 2024
Merged

Conversation

Eric-Arellano
Copy link
Collaborator

@Eric-Arellano Eric-Arellano commented Jun 4, 2024

This is a new file since we came up with the original docs migration plan.

circuit-execution left ToC Screenshot 2024-06-04 at 1 02 20 PM
circuit-execution patterns index page Screenshot 2024-06-04 at 1 03 00 PM
operator-class left ToC Screenshot 2024-06-18 at 1 57 36 PM
operator-class patterns index page Screenshot 2024-06-18 at 1 54 50 PM
error-mitigation-and-suppression-techniques left ToC Screenshot 2024-06-18 at 1 57 11 PM
error-mitigation-and-suppression-techniques patterns index page Screenshot 2024-06-18 at 1 56 47 PM

@Eric-Arellano
Copy link
Collaborator Author

Reviewers, please confirm that you like where the page shows up in the screenshots in the PR description, and that you like the new URL guides/circuit-execution

@Eric-Arellano Eric-Arellano changed the title Add circuit-execution.mdx to docs migration Add three new pages to docs migration Jun 18, 2024
@@ -356,6 +361,11 @@
slug="/advanced-runtime-options",
from_file="run/advanced-runtime-options.mdx",
),
Entry(
"Error mitigation and suppression techniques",
slug="/error-mitigation-and-suppression-techniques",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this is a new URL proposed by @abbycross

@@ -408,6 +418,11 @@
slug="/run-jobs-batch",
from_file="run/run-jobs-batch.mdx",
),
Entry(
"Fixed and dynamic repetition rate execution",
slug="/circuit-execution",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this new URL overly generic?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm yeah it feels a bit generic to me, but i think thats the same as the path we're currently using so probably fine to keep it as is

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now is our best opportunity to rename it because we get the redirect for "free", like we need a redirect anyways. @abbycross any ideas for a better URL?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about /repetition-rate-execution unless it feels at all possible we'll have a similarly-named file in the future?...

Copy link
Collaborator

@javabster javabster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Eric-Arellano Eric-Arellano enabled auto-merge June 18, 2024 21:08
@Eric-Arellano Eric-Arellano added this pull request to the merge queue Jun 18, 2024
Merged via the queue into main with commit 02f32be Jun 18, 2024
2 checks passed
@Eric-Arellano Eric-Arellano deleted the EA/migrate-circuit-execution branch June 18, 2024 21:13
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
This is a new file since we came up with the original docs migration
plan.

<details><summary>circuit-execution left ToC</summary>

<img width="268" alt="Screenshot 2024-06-04 at 1 02 20 PM"
src="https://github.com/Qiskit/documentation/assets/14852634/25d74746-e1df-4687-9155-450a2c418000">
</details>

<details><summary>circuit-execution patterns index page</summary>

<img width="440" alt="Screenshot 2024-06-04 at 1 03 00 PM"
src="https://github.com/Qiskit/documentation/assets/14852634/97ab4324-a263-41ac-b4a3-48760e048878">
</details>


<details><summary>operator-class left ToC</summary>

<img width="258" alt="Screenshot 2024-06-18 at 1 57 36 PM"
src="https://github.com/Qiskit/documentation/assets/14852634/c96df34b-e3b3-4a0a-b847-d70286239d72">
</details>

<details><summary>operator-class patterns index page</summary>
<img width="424" alt="Screenshot 2024-06-18 at 1 54 50 PM"
src="https://github.com/Qiskit/documentation/assets/14852634/9cd034ca-463a-4fa9-87dc-b94791922abe">

</details>


<details><summary>error-mitigation-and-suppression-techniques left
ToC</summary>

<img width="260" alt="Screenshot 2024-06-18 at 1 57 11 PM"
src="https://github.com/Qiskit/documentation/assets/14852634/e6d0c74e-6ca2-4263-a592-a797cc8acec8">
</details>


<details><summary>error-mitigation-and-suppression-techniques patterns
index page</summary>

<img width="398" alt="Screenshot 2024-06-18 at 1 56 47 PM"
src="https://github.com/Qiskit/documentation/assets/14852634/c4f13b5c-7177-4f01-b6a3-374613aaf809">
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants