-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add three new pages to docs migration #1494
Conversation
Reviewers, please confirm that you like where the page shows up in the screenshots in the PR description, and that you like the new URL |
@@ -356,6 +361,11 @@ | |||
slug="/advanced-runtime-options", | |||
from_file="run/advanced-runtime-options.mdx", | |||
), | |||
Entry( | |||
"Error mitigation and suppression techniques", | |||
slug="/error-mitigation-and-suppression-techniques", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this is a new URL proposed by @abbycross
scripts/patterns-reorg/entries.py
Outdated
@@ -408,6 +418,11 @@ | |||
slug="/run-jobs-batch", | |||
from_file="run/run-jobs-batch.mdx", | |||
), | |||
Entry( | |||
"Fixed and dynamic repetition rate execution", | |||
slug="/circuit-execution", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this new URL overly generic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm yeah it feels a bit generic to me, but i think thats the same as the path we're currently using so probably fine to keep it as is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now is our best opportunity to rename it because we get the redirect for "free", like we need a redirect anyways. @abbycross any ideas for a better URL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about /repetition-rate-execution
unless it feels at all possible we'll have a similarly-named file in the future?...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
This is a new file since we came up with the original docs migration plan. <details><summary>circuit-execution left ToC</summary> <img width="268" alt="Screenshot 2024-06-04 at 1 02 20 PM" src="https://github.com/Qiskit/documentation/assets/14852634/25d74746-e1df-4687-9155-450a2c418000"> </details> <details><summary>circuit-execution patterns index page</summary> <img width="440" alt="Screenshot 2024-06-04 at 1 03 00 PM" src="https://github.com/Qiskit/documentation/assets/14852634/97ab4324-a263-41ac-b4a3-48760e048878"> </details> <details><summary>operator-class left ToC</summary> <img width="258" alt="Screenshot 2024-06-18 at 1 57 36 PM" src="https://github.com/Qiskit/documentation/assets/14852634/c96df34b-e3b3-4a0a-b847-d70286239d72"> </details> <details><summary>operator-class patterns index page</summary> <img width="424" alt="Screenshot 2024-06-18 at 1 54 50 PM" src="https://github.com/Qiskit/documentation/assets/14852634/9cd034ca-463a-4fa9-87dc-b94791922abe"> </details> <details><summary>error-mitigation-and-suppression-techniques left ToC</summary> <img width="260" alt="Screenshot 2024-06-18 at 1 57 11 PM" src="https://github.com/Qiskit/documentation/assets/14852634/e6d0c74e-6ca2-4263-a592-a797cc8acec8"> </details> <details><summary>error-mitigation-and-suppression-techniques patterns index page</summary> <img width="398" alt="Screenshot 2024-06-18 at 1 56 47 PM" src="https://github.com/Qiskit/documentation/assets/14852634/c4f13b5c-7177-4f01-b6a3-374613aaf809"> </details>
This is a new file since we came up with the original docs migration plan.
circuit-execution left ToC
circuit-execution patterns index page
operator-class left ToC
operator-class patterns index page
error-mitigation-and-suppression-techniques left ToC
error-mitigation-and-suppression-techniques patterns index page