Use internal links for new index page #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankharkins
pushed a commit
to frankharkins/documentation
that referenced
this pull request
Jul 22, 2024
We shouldn't be using external links in general. This PR also updates to use the new `guides/` URLs. Note that we have some risk that the links we hardcode here diverge from our source of truth in `entries.py`. We can't have `page_content.py` load the final URLs from `entries.py` because it would result in a circular import. However, our link checker will complain if there are any divergences, so it should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't be using external links in general.
This PR also updates to use the new
guides/URLs. Note that we have some risk that the links we hardcode here diverge from our source of truth inentries.py. We can't havepage_content.pyload the final URLs fromentries.pybecause it would result in a circular import. However, our link checker will complain if there are any divergences, so it should be fine.