Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set redirects for future deleted pages in the patterns reorg #1497

Merged
merged 14 commits into from
Jun 5, 2024

Conversation

arnaucasau
Copy link
Collaborator

@arnaucasau arnaucasau commented Jun 5, 2024

This PR adds a new class called DeletedPage that we can use to set redirects for pages that will be removed after the reorg.

The PR also adds some redirects for the index pages of the old folders duplicating the entries to match the two ways they can be used. An index page can be accessed by using the name of the parent folder or by specifying the index file. For example, the run index can be accessed by going to /run/ or /run/index.

@arnaucasau arnaucasau changed the title [WIP] Add script to update all the non-API links to guides/ Add an option to set redirects for future deleted pages in the patterns reorg Jun 5, 2024
@arnaucasau arnaucasau marked this pull request as ready for review June 5, 2024 16:12
@qiskit-bot
Copy link
Contributor

Thanks for contributing to Qiskit documentation!

Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌

scripts/patterns-reorg/models.py Outdated Show resolved Hide resolved
scripts/patterns-reorg/models.py Outdated Show resolved Hide resolved
scripts/patterns-reorg/models.py Outdated Show resolved Hide resolved
scripts/patterns-reorg/models.py Outdated Show resolved Hide resolved
scripts/patterns-reorg/models.py Outdated Show resolved Hide resolved
scripts/patterns-reorg/redirects.json Outdated Show resolved Hide resolved
arnaucasau and others added 4 commits June 5, 2024 18:52
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
@Eric-Arellano Eric-Arellano changed the title Add an option to set redirects for future deleted pages in the patterns reorg Set redirects for future deleted pages in the patterns reorg Jun 5, 2024
Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

scripts/patterns-reorg/deleted_entries.py Outdated Show resolved Hide resolved
scripts/patterns-reorg/models.py Outdated Show resolved Hide resolved
arnaucasau and others added 2 commits June 5, 2024 19:49
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
@arnaucasau arnaucasau added this pull request to the merge queue Jun 5, 2024
Merged via the queue into Qiskit:main with commit d8aace6 Jun 5, 2024
2 checks passed
@arnaucasau arnaucasau deleted the AC/update-internal-links branch June 5, 2024 17:59
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
…1497)

This PR adds a new class called `DeletedPage` that we can use to set
redirects for pages that will be removed after the reorg.

The PR also adds some redirects for the index pages of the old folders
duplicating the entries to match the two ways they can be used. An index
page can be accessed by using the name of the parent folder or by
specifying the index file. For example, the `run` index can be accessed
by going to `/run/` or `/run/index`.

---------

Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants