-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script to update all non-API links to guides/
#1498
Add script to update all non-API links to guides/
#1498
Conversation
Thanks for contributing to Qiskit documentation! Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Could you please have this generate the links to be like [quantum circuits](./construct-circuits)
rather than [quantum circuits](construct-circuits)
, i.e. with the dot? While it's not necessary, imo it's more obvious to the reader what's going on. Better for grep also
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good after this last change
Closes Qiskit#1460 This PR adds a script to update all the non-API links to point to `guides/` taking into account that all the files will now be in the same folder, and there's no need to preserve the relative paths
Closes #1460
This PR adds a script to update all the non-API links to point to
guides/
taking into account that all the files will now be in the same folder, and there's no need to preserve the relative paths