Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to update all non-API links to guides/ #1498

Merged
merged 7 commits into from
Jun 5, 2024

Conversation

arnaucasau
Copy link
Collaborator

Closes #1460

This PR adds a script to update all the non-API links to point to guides/ taking into account that all the files will now be in the same folder, and there's no need to preserve the relative paths

@arnaucasau arnaucasau marked this pull request as ready for review June 5, 2024 16:24
@qiskit-bot
Copy link
Contributor

Thanks for contributing to Qiskit documentation!

Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌

scripts/patterns-reorg/update_internal_links.py Outdated Show resolved Hide resolved
scripts/patterns-reorg/update_internal_links.py Outdated Show resolved Hide resolved
scripts/patterns-reorg/update_internal_links.py Outdated Show resolved Hide resolved
scripts/patterns-reorg/update_internal_links.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Could you please have this generate the links to be like [quantum circuits](./construct-circuits) rather than [quantum circuits](construct-circuits), i.e. with the dot? While it's not necessary, imo it's more obvious to the reader what's going on. Better for grep also

scripts/patterns-reorg/main.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good after this last change

scripts/patterns-reorg/main.py Outdated Show resolved Hide resolved
@Eric-Arellano Eric-Arellano added this pull request to the merge queue Jun 5, 2024
Merged via the queue into Qiskit:main with commit b4df2d0 Jun 5, 2024
2 checks passed
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Closes Qiskit#1460

This PR adds a script to update all the non-API links to point to
`guides/` taking into account that all the files will now be in the same
folder, and there's no need to preserve the relative paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Patterns: update all non-API links to guides/
3 participants