Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[do not merge] Test execute notebooks CI #1537

Closed
wants to merge 2 commits into from
Closed

Conversation

arnaucasau
Copy link
Collaborator

@arnaucasau arnaucasau commented Jun 12, 2024

Do not merge, this PR is to try if CI breaks executing the modified notebook

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@frankharkins
Copy link
Member

This is failing due to #1552, not because of a problem with your script. I'm not sure how this notebook made it into the repo... maybe before we started testing with Python 3.9?

@arnaucasau
Copy link
Collaborator Author

arnaucasau commented Jun 14, 2024

Oh, I see. Thanks for looking into this Frank! I can make the changes if you want, so feel free to assign the issue to me.

I found that /run/save-jobs.ipynb also fails with the message Unable to retrieve result for job csnfd2mp1vzg008ab670. Job was cancelled. as you can see in 3606f1b 🤔 .

@arnaucasau
Copy link
Collaborator Author

Closing the PR because we have issues tracking the "broken" notebooks. Thank you @frankharkins for your help :)

@arnaucasau arnaucasau closed this Jun 17, 2024
@arnaucasau arnaucasau deleted the AC/test-notebook-ci branch July 2, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants