Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patterns index validation #1550

Merged
merged 11 commits into from
Jun 19, 2024

Conversation

arnaucasau
Copy link
Collaborator

@arnaucasau arnaucasau commented Jun 14, 2024

Closes #1299

This PR adds a script that validates that every page shows up both in the Tools folders and in the Workflow index pages.

@arnaucasau arnaucasau changed the title [WIP] Add patterns index validation Add patterns index validation Jun 17, 2024
@arnaucasau arnaucasau marked this pull request as ready for review June 17, 2024 14:17
@qiskit-bot
Copy link
Contributor

Thanks for contributing to Qiskit documentation!

Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌

Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

scripts/commands/checkPatternsIndex.ts Outdated Show resolved Hide resolved
scripts/commands/checkPatternsIndex.ts Outdated Show resolved Hide resolved
scripts/commands/checkPatternsIndex.ts Outdated Show resolved Hide resolved
scripts/commands/checkPatternsIndex.ts Outdated Show resolved Hide resolved
scripts/commands/checkPatternsIndex.ts Outdated Show resolved Hide resolved
scripts/commands/checkPatternsIndex.ts Outdated Show resolved Hide resolved
scripts/commands/checkPatternsIndex.ts Outdated Show resolved Hide resolved
scripts/commands/checkPatternsIndex.ts Outdated Show resolved Hide resolved
scripts/commands/checkPatternsIndex.ts Outdated Show resolved Hide resolved
scripts/commands/checkPatternsIndex.ts Outdated Show resolved Hide resolved
arnaucasau and others added 4 commits June 18, 2024 15:28
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
scripts/commands/checkPatternsIndex.ts Outdated Show resolved Hide resolved
scripts/commands/checkPatternsIndex.ts Outdated Show resolved Hide resolved
scripts/commands/checkPatternsIndex.ts Outdated Show resolved Hide resolved
scripts/commands/checkPatternsIndex.ts Outdated Show resolved Hide resolved
scripts/commands/checkPatternsIndex.ts Outdated Show resolved Hide resolved
scripts/commands/checkPatternsIndex.ts Outdated Show resolved Hide resolved
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside of the last nit, this looks good. Thanks!

@arnaucasau arnaucasau added this pull request to the merge queue Jun 19, 2024
Merged via the queue into Qiskit:main with commit 61c6c00 Jun 19, 2024
2 checks passed
@arnaucasau arnaucasau deleted the AC/validate-patterns-index branch June 19, 2024 13:06
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Closes Qiskit#1299

This PR adds a script that validates that every page shows up both in
the Tools folders and in the Workflow index pages.

---------

Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Patterns: validate Patterns index pages include all guides
3 participants