Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up skeleton for Additional Resources dropdown #1671

Merged
merged 6 commits into from
Jul 16, 2024

Conversation

Eric-Arellano
Copy link
Collaborator

@Eric-Arellano Eric-Arellano commented Jul 9, 2024

This sets up the new URLs for the /open-source folder (#605) and the /responsible-quantum-computing page (#1576).

The content is not yet synced to production. This only sets up the empty pages and _toc.json so that we can develop the content more easily.

--

Note that the URLs do not have /additional-resources/ or /resources in them. We decided this in #1360 so that the URLs are shorter and more flexible to future reorganization.

/responsible-quantum-computing is not in a folder and does not have _toc.json because it is a standalone page, similar to /support. If we ever decide to expand it into a folder, we can do that by adding a /responsible-quantum-computing, so long as we add an index.mdx file.

Migration guides will be moved over once we are ready with redirects. (They actually technically never have to be moved.)

Screenshot 2024-07-15 at 9 47 18 AM

@Eric-Arellano Eric-Arellano force-pushed the EA/set-up-resources branch from 2fb32d6 to 3fdaea3 Compare July 9, 2024 17:47
@@ -0,0 +1,40 @@
{
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewers: pay attention to the file names and URLs. This is what makes up the left ToC. This ToC reflects the Qiskit dev meeting this morning: #605 (comment)

(We can always adjust things until this goes live)

docs/open-source/_toc.json Show resolved Hide resolved
"title": "Qiskit SDK",
"children": [
{
"title": "Version strategy",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is aka the deprecation policy. It explains what the policy is, whereas the DEPRECATION.md file in qiskit repo explains the tactics of how maintainers write deprecations.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont see the deprecation policy line in this file? Or is the diff just bad? I just see version strategy then contributor guide

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were thinking the deprecation guide should be linked inside the "Version strategy" file, rather than having a dedicated external link in the left ToC. What do you prefer? We can add an external link like "Deprecation techniques" or "Deprecation guide"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok yeah keeping it in the version strategy page is fine by me 👍

"url": "/open-source/qiskit-sdk-version-strategy"
},
{
"title": "Contributor guide",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk if there's a better name

"url": "https://github.com/Qiskit/qiskit/blob/main/CONTRIBUTING.md"
},
{
"title": "Maintainer guide",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk if there's a better name

@@ -0,0 +1,119 @@
---
title: Code of conduct
description: TODO
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be done before the folder goes live in 2-3 weeks. Idk if we want to do it now, or later?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could fill it now: "The Qiskit Code of Conduct defines and enforces the values and conduct of contributors and participants in the Qiskit open source community."

description: TODO
---

# Code of Conduct
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The below is copied from Qiskit SDK repo

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you talk with the qiskit devs about this page? I'm not sure if we should copy-paste it in here or just use an external link?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't talk to them about whether it should be in the docs page vs a link to Qiskit SDK repo. @1ucian0 any thoughts?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with duplicating the page, i think it's important content, but we just need to make sure it doesn't go out of date if the qiskit repo version changes

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just chatted with luciano, neither of us feel strongly about wether it should be in docs or a link out, so lets just go with whatever is simpler to implement :D

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify, I was envisioning updating Qiskit/qiskit to point to the page once it goes live with text like:

This project follows the code of conduct at docs.quantum.ibm.com/open-source/code-of-conduct.

@@ -0,0 +1,8 @@
---
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can fill in this content later

@@ -0,0 +1,6 @@
---
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note there is no _toc.json and this is in the top-level docs folder

@Eric-Arellano
Copy link
Collaborator Author

Bump @abbycross @javabster

@abbycross
Copy link
Collaborator

I think I misunderstood @Eric-Arellano - this will go into production but not show up in publication until we populate the files? Or would we use this unmerged branch to build the content?

@Eric-Arellano
Copy link
Collaborator Author

Eric-Arellano commented Jul 11, 2024

@abbycross this will be merged to qiskit/documentation, but not synced to the closed source repo until we tell it to be. So, these files will not go live in production at all.

The motivation for merging this now is to facilitate future PRs in qiskit/documentation.

Copy link
Collaborator

@abbycross abbycross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (would like @javabster and others to weigh in on file naming but this makes sense to me!)

@Eric-Arellano
Copy link
Collaborator Author

@javabster feel free to merge this or make any changes you want while I'm OOO tomorrow

Eric-Arellano and others added 2 commits July 16, 2024 06:22
Co-authored-by: Abby Mitchell <23662430+javabster@users.noreply.github.com>
@Eric-Arellano Eric-Arellano enabled auto-merge July 16, 2024 10:23
@Eric-Arellano Eric-Arellano added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit 88fbdf2 Jul 16, 2024
3 checks passed
@Eric-Arellano Eric-Arellano deleted the EA/set-up-resources branch July 16, 2024 10:29
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
This sets up the new URLs for the `/open-source` folder
(Qiskit#605) and the
`/responsible-quantum-computing` page
(Qiskit#1576).

The content is not yet synced to production. This only sets up the empty
pages and `_toc.json` so that we can develop the content more easily.

--

Note that the URLs do not have `/additional-resources/` or `/resources`
in them. We decided this in
Qiskit#1360 so that the URLs are
shorter and more flexible to future reorganization.

`/responsible-quantum-computing` is not in a folder and does not have
`_toc.json` because it is a standalone page, similar to `/support`. If
we ever decide to expand it into a folder, we can do that by adding a
`/responsible-quantum-computing`, so long as we add an `index.mdx` file.

Migration guides will be moved over once we are ready with redirects.
(They actually technically never have to be moved.)

<img width="267" alt="Screenshot 2024-07-15 at 9 47 18 AM"
src="https://github.com/user-attachments/assets/47836660-63fa-494f-8a4b-aba3fc427059">

---------

Co-authored-by: Abby Mitchell <23662430+javabster@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants