Reduce chance of save-jobs.ipynb failing in CI
#2386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Eric-Arellano
approved these changes
Nov 25, 2024
|
I actually didn't really notice much difference between 10 and 1000, just setting it to |
|
Sg, 1000 makes sense then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is
service.jobs()by default only gets the past 10 jobs. Usually this is fine, but there's a chance the past 10 jobs we've submitted have all been cancelled or have failed.This PR reduces the change of CI failing by increasing the number of jobs we collect. We can remove the limit by setting
limit=None, but this takes too long to execute. I've picked 1000 as a compromise.This is ready for review, but don't merge until after #2382 is merged. When that happens, I'll pull main and re-run this notebook to update it.