Improve ./start to work on Windows
#2421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: confirm with @beckykd this fixes things. |
|
@frankharkins @arnaucasau before landing this, please see if the status quo works with Git Bash for Becky. If it does, please confirm this change does not break Git Bash and it also fixes PowerShell. Imo supporting PowerShell is not essential, so long as Git Bash works on Windows. No worries if this PR doesn't fix PowerShell, so long as Git Bash works. |
Eric-Arellano
commented
Dec 17, 2024
Eric-Arellano
changed the title
./start to work on Windows./start to work on Windows
|
We got it working on both Powershell and Git Bash 🚀 |
|
@arnaucasau @frankharkins bump on reviewing this please |
arnaucasau
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1607. There are two issues:
python ./startinstead of./start